Checkstyle Results

The following document contains the results of Checkstyle 9.1 with sun_checks.xml ruleset. 

rss feed

Summary

Files
 Info
 Warnings
 Errors
8 0 0 217

Files

File
 I
 W
 E
ua/lviv/iot/Main.java 0 0 50
ua/lviv/iot/manager/EquipmentWriter.java 0 0 8
ua/lviv/iot/manager/FilmStudio.java 0 0 32
ua/lviv/iot/models/Camera.java 0 0 30
ua/lviv/iot/models/Decorations.java 0 0 25
ua/lviv/iot/models/Equipment.java 0 0 32
ua/lviv/iot/models/EquipmentBox.java 0 0 6
ua/lviv/iot/models/Lighting.java 0 0 34

Rules

Category Rule Violations Severity
blocks NeedBraces 11
 Error
coding HiddenField 9
 Error
MagicNumber 15
 Error
design DesignForExtension 29
 Error
HideUtilityClassConstructor 1
 Error
VisibilityModifier 4
 Error
imports AvoidStarImport 3
 Error
javadoc JavadocPackage 3
 Error
JavadocVariable 10
 Error
MissingJavadocMethod 18
 Error
misc FinalParameters 28
 Error
sizes LineLength
  • fileExtensions: "java"
42
 Error
whitespace FileTabCharacter 8
 Error
OperatorWrap 22
 Error
WhitespaceAfter 14
 Error

Details

ua/lviv/iot/Main.java

Severity Category Rule Message Line
 Error
javadoc JavadocPackage Missing package-info.java file. 1
 Error
imports AvoidStarImport Using the '.*' form of import should be avoided - ua.lviv.iot.manager.*. 3
 Error
imports AvoidStarImport Using the '.*' form of import should be avoided - ua.lviv.iot.models.*. 4
 Error
design HideUtilityClassConstructor Utility classes should not have a public or default constructor. 6
 Error
whitespace FileTabCharacter File contains tab characters (this is the first instance). 7
 Error
javadoc MissingJavadocMethod Missing a Javadoc comment. 7
 Error
misc FinalParameters Parameter args should be final. 7
 Error
sizes LineLength Line is longer than 80 characters (found 101). 8
 Error
sizes LineLength Line is longer than 80 characters (found 97). 11
 Error
coding MagicNumber '70499' is a magic number. 12
 Error
coding MagicNumber '24' is a magic number. 13
 Error
whitespace WhitespaceAfter ',' is not followed by whitespace. 13
 Error
coding MagicNumber '10' is a magic number. 13
 Error
whitespace WhitespaceAfter ',' is not followed by whitespace. 13
 Error
coding MagicNumber '14' is a magic number. 13
 Error
whitespace WhitespaceAfter ',' is not followed by whitespace. 13
 Error
sizes LineLength Line is longer than 80 characters (found 92). 14
 Error
coding MagicNumber '200' is a magic number. 15
 Error
coding MagicNumber '28' is a magic number. 16
 Error
whitespace WhitespaceAfter ',' is not followed by whitespace. 16
 Error
coding MagicNumber '5' is a magic number. 16
 Error
whitespace WhitespaceAfter ',' is not followed by whitespace. 16
 Error
coding MagicNumber '8' is a magic number. 16
 Error
whitespace WhitespaceAfter ',' is not followed by whitespace. 16
 Error
sizes LineLength Line is longer than 80 characters (found 89). 17
 Error
whitespace WhitespaceAfter ',' is not followed by whitespace. 18
 Error
coding MagicNumber '20' is a magic number. 18
 Error
whitespace WhitespaceAfter ',' is not followed by whitespace. 18
 Error
coding MagicNumber '50' is a magic number. 18
 Error
whitespace WhitespaceAfter ',' is not followed by whitespace. 18
 Error
coding MagicNumber '4500' is a magic number. 18
 Error
coding MagicNumber '50' is a magic number. 19
 Error
whitespace WhitespaceAfter ',' is not followed by whitespace. 19
 Error
coding MagicNumber '30' is a magic number. 19
 Error
whitespace WhitespaceAfter ',' is not followed by whitespace. 19
 Error
sizes LineLength Line is longer than 80 characters (found 103). 20
 Error
coding MagicNumber '45000' is a magic number. 21
 Error
whitespace WhitespaceAfter ',' is not followed by whitespace. 22
 Error
coding MagicNumber '560' is a magic number. 22
 Error
whitespace WhitespaceAfter ',' is not followed by whitespace. 22
 Error
sizes LineLength Line is longer than 80 characters (found 105). 26
 Error
sizes LineLength Line is longer than 80 characters (found 87). 28
 Error
sizes LineLength Line is longer than 80 characters (found 97). 31
 Error
sizes LineLength Line is longer than 80 characters (found 97). 36
 Error
sizes LineLength Line is longer than 80 characters (found 97). 41
 Error
sizes LineLength Line is longer than 80 characters (found 92). 42
 Error
sizes LineLength Line is longer than 80 characters (found 97). 46
 Error
sizes LineLength Line is longer than 80 characters (found 99). 47
 Error
sizes LineLength Line is longer than 80 characters (found 97). 51
 Error
sizes LineLength Line is longer than 80 characters (found 95). 52

ua/lviv/iot/manager/EquipmentWriter.java

Severity Category Rule Message Line
 Error
whitespace FileTabCharacter File contains tab characters (this is the first instance). 12
 Error
sizes LineLength Line is longer than 80 characters (found 92). 16
 Error
javadoc MissingJavadocMethod Missing a Javadoc comment. 16
 Error
misc FinalParameters Parameter equipmentBox should be final. 16
 Error
sizes LineLength Line is longer than 80 characters (found 92). 20
 Error
sizes LineLength Line is longer than 80 characters (found 102). 25
 Error
sizes LineLength Line is longer than 80 characters (found 81). 29
 Error
sizes LineLength Line is longer than 80 characters (found 97). 31

ua/lviv/iot/manager/FilmStudio.java

Severity Category Rule Message Line
 Error
javadoc JavadocPackage Missing package-info.java file. 1
 Error
imports AvoidStarImport Using the '.*' form of import should be avoided - java.util.*. 7
 Error
whitespace FileTabCharacter File contains tab characters (this is the first instance). 11
 Error
javadoc JavadocVariable Missing a Javadoc comment. 11
 Error
design VisibilityModifier Variable 'equipmentList' must be private and have accessor methods. 11
 Error
design DesignForExtension Class 'FilmStudio' looks like designed for extension (can be subclassed), but the method 'addNewEquipment' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'FilmStudio' final or making the method 'addNewEquipment' static/final/abstract/empty, or adding allowed annotation for the method. 13
 Error
javadoc MissingJavadocMethod Missing a Javadoc comment. 13
 Error
misc FinalParameters Parameter equipmentBoxes should be final. 13
 Error
design DesignForExtension Class 'FilmStudio' looks like designed for extension (can be subclassed), but the method 'printEquipment' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'FilmStudio' final or making the method 'printEquipment' static/final/abstract/empty, or adding allowed annotation for the method. 21
 Error
javadoc MissingJavadocMethod Missing a Javadoc comment. 21
 Error
sizes LineLength Line is longer than 80 characters (found 81). 22
 Error
design DesignForExtension Class 'FilmStudio' looks like designed for extension (can be subclassed), but the method 'getEquipmentSortedByPrice' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'FilmStudio' final or making the method 'getEquipmentSortedByPrice' static/final/abstract/empty, or adding allowed annotation for the method. 28
 Error
javadoc MissingJavadocMethod Missing a Javadoc comment. 28
 Error
misc FinalParameters Parameter reverse should be final. 28
 Error
sizes LineLength Line is longer than 80 characters (found 123). 29
 Error
sizes LineLength Line is longer than 80 characters (found 86). 30
 Error
design DesignForExtension Class 'FilmStudio' looks like designed for extension (can be subclassed), but the method 'getRentedEquipment' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'FilmStudio' final or making the method 'getRentedEquipment' static/final/abstract/empty, or adding allowed annotation for the method. 39
 Error
javadoc MissingJavadocMethod Missing a Javadoc comment. 39
 Error
sizes LineLength Line is longer than 80 characters (found 102). 40
 Error
design DesignForExtension Class 'FilmStudio' looks like designed for extension (can be subclassed), but the method 'getDecorationsByGenre' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'FilmStudio' final or making the method 'getDecorationsByGenre' static/final/abstract/empty, or adding allowed annotation for the method. 43
 Error
javadoc MissingJavadocMethod Missing a Javadoc comment. 43
 Error
misc FinalParameters Parameter genre should be final. 43
 Error
sizes LineLength Line is longer than 80 characters (found 125). 45
 Error
sizes LineLength Line is longer than 80 characters (found 123). 46
 Error
whitespace WhitespaceAfter 'typecast' is not followed by whitespace. 46
 Error
sizes LineLength Line is longer than 80 characters (found 93). 47
 Error
sizes LineLength Line is longer than 80 characters (found 81). 51
 Error
design DesignForExtension Class 'FilmStudio' looks like designed for extension (can be subclassed), but the method 'getEquipmentSortedByManufacturer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'FilmStudio' final or making the method 'getEquipmentSortedByManufacturer' static/final/abstract/empty, or adding allowed annotation for the method. 51
 Error
javadoc MissingJavadocMethod Missing a Javadoc comment. 51
 Error
misc FinalParameters Parameter reverse should be final. 51
 Error
sizes LineLength Line is longer than 80 characters (found 119). 52
 Error
sizes LineLength Line is longer than 80 characters (found 86). 53

ua/lviv/iot/models/Camera.java

Severity Category Rule Message Line
 Error
whitespace FileTabCharacter File contains tab characters (this is the first instance). 6
 Error
javadoc JavadocVariable Missing a Javadoc comment. 6
 Error
javadoc JavadocVariable Missing a Javadoc comment. 7
 Error
sizes LineLength Line is longer than 80 characters (found 110). 9
 Error
javadoc MissingJavadocMethod Missing a Javadoc comment. 9
 Error
misc FinalParameters Parameter manufacturer should be final. 9
 Error
misc FinalParameters Parameter isRented should be final. 9
 Error
misc FinalParameters Parameter priceInUAH should be final. 9
 Error
misc FinalParameters Parameter model should be final. 9
 Error
coding HiddenField 'model' hides a field. 9
 Error
misc FinalParameters Parameter megapixels should be final. 9
 Error
coding HiddenField 'megapixels' hides a field. 9
 Error
design DesignForExtension Class 'Camera' looks like designed for extension (can be subclassed), but the method 'toCSV' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Camera' final or making the method 'toCSV' static/final/abstract/empty, or adding allowed annotation for the method. 15
 Error
sizes LineLength Line is longer than 80 characters (found 87). 17
 Error
design DesignForExtension Class 'Camera' looks like designed for extension (can be subclassed), but the method 'getHeaders' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Camera' final or making the method 'getHeaders' static/final/abstract/empty, or adding allowed annotation for the method. 20
 Error
sizes LineLength Line is longer than 80 characters (found 84). 22
 Error
design DesignForExtension Class 'Camera' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Camera' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. 25
 Error
whitespace OperatorWrap '+' should be on a new line. 27
 Error
whitespace OperatorWrap '+' should be on a new line. 28
 Error
whitespace OperatorWrap '+' should be on a new line. 29
 Error
whitespace OperatorWrap '+' should be on a new line. 30
 Error
whitespace OperatorWrap '+' should be on a new line. 31
 Error
whitespace OperatorWrap '+' should be on a new line. 32
 Error
design DesignForExtension Class 'Camera' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Camera' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. 36
 Error
misc FinalParameters Parameter o should be final. 37
 Error
blocks NeedBraces 'if' construct must use '{}'s. 38
 Error
blocks NeedBraces 'if' construct must use '{}'s. 39
 Error
blocks NeedBraces 'if' construct must use '{}'s. 40
 Error
sizes LineLength Line is longer than 80 characters (found 94). 42
 Error
design DesignForExtension Class 'Camera' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Camera' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. 45

ua/lviv/iot/models/Decorations.java

Severity Category Rule Message Line
 Error
whitespace FileTabCharacter File contains tab characters (this is the first instance). 6
 Error
javadoc JavadocVariable Missing a Javadoc comment. 6
 Error
sizes LineLength Line is longer than 80 characters (found 103). 8
 Error
javadoc MissingJavadocMethod Missing a Javadoc comment. 8
 Error
misc FinalParameters Parameter manufacturer should be final. 8
 Error
misc FinalParameters Parameter isRented should be final. 8
 Error
misc FinalParameters Parameter priceInUAH should be final. 8
 Error
misc FinalParameters Parameter filmGenre should be final. 8
 Error
coding HiddenField 'filmGenre' hides a field. 8
 Error
design DesignForExtension Class 'Decorations' looks like designed for extension (can be subclassed), but the method 'getFilmGenre' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Decorations' final or making the method 'getFilmGenre' static/final/abstract/empty, or adding allowed annotation for the method. 13
 Error
javadoc MissingJavadocMethod Missing a Javadoc comment. 13
 Error
design DesignForExtension Class 'Decorations' looks like designed for extension (can be subclassed), but the method 'toCSV' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Decorations' final or making the method 'toCSV' static/final/abstract/empty, or adding allowed annotation for the method. 17
 Error
design DesignForExtension Class 'Decorations' looks like designed for extension (can be subclassed), but the method 'getHeaders' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Decorations' final or making the method 'getHeaders' static/final/abstract/empty, or adding allowed annotation for the method. 22
 Error
design DesignForExtension Class 'Decorations' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Decorations' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. 27
 Error
whitespace OperatorWrap '+' should be on a new line. 29
 Error
whitespace OperatorWrap '+' should be on a new line. 30
 Error
whitespace OperatorWrap '+' should be on a new line. 31
 Error
whitespace OperatorWrap '+' should be on a new line. 32
 Error
whitespace OperatorWrap '+' should be on a new line. 33
 Error
design DesignForExtension Class 'Decorations' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Decorations' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. 37
 Error
misc FinalParameters Parameter o should be final. 38
 Error
blocks NeedBraces 'if' construct must use '{}'s. 39
 Error
blocks NeedBraces 'if' construct must use '{}'s. 40
 Error
blocks NeedBraces 'if' construct must use '{}'s. 41
 Error
design DesignForExtension Class 'Decorations' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Decorations' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. 46

ua/lviv/iot/models/Equipment.java

Severity Category Rule Message Line
 Error
javadoc JavadocPackage Missing package-info.java file. 1
 Error
whitespace FileTabCharacter File contains tab characters (this is the first instance). 6
 Error
javadoc JavadocVariable Missing a Javadoc comment. 6
 Error
design VisibilityModifier Variable 'manufacturer' must be private and have accessor methods. 6
 Error
javadoc JavadocVariable Missing a Javadoc comment. 7
 Error
design VisibilityModifier Variable 'isRented' must be private and have accessor methods. 7
 Error
javadoc JavadocVariable Missing a Javadoc comment. 8
 Error
design VisibilityModifier Variable 'priceInUAH' must be private and have accessor methods. 8
 Error
design DesignForExtension Class 'Equipment' looks like designed for extension (can be subclassed), but the method 'getManufacturer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Equipment' final or making the method 'getManufacturer' static/final/abstract/empty, or adding allowed annotation for the method. 10
 Error
javadoc MissingJavadocMethod Missing a Javadoc comment. 10
 Error
design DesignForExtension Class 'Equipment' looks like designed for extension (can be subclassed), but the method 'isRented' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Equipment' final or making the method 'isRented' static/final/abstract/empty, or adding allowed annotation for the method. 14
 Error
javadoc MissingJavadocMethod Missing a Javadoc comment. 14
 Error
design DesignForExtension Class 'Equipment' looks like designed for extension (can be subclassed), but the method 'getPriceInUAH' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Equipment' final or making the method 'getPriceInUAH' static/final/abstract/empty, or adding allowed annotation for the method. 18
 Error
javadoc MissingJavadocMethod Missing a Javadoc comment. 18
 Error
sizes LineLength Line is longer than 80 characters (found 83). 22
 Error
javadoc MissingJavadocMethod Missing a Javadoc comment. 22
 Error
misc FinalParameters Parameter manufacturer should be final. 22
 Error
coding HiddenField 'manufacturer' hides a field. 22
 Error
misc FinalParameters Parameter isRented should be final. 22
 Error
coding HiddenField 'isRented' hides a field. 22
 Error
misc FinalParameters Parameter priceInUAH should be final. 22
 Error
coding HiddenField 'priceInUAH' hides a field. 22
 Error
design DesignForExtension Class 'Equipment' looks like designed for extension (can be subclassed), but the method 'toCSV' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Equipment' final or making the method 'toCSV' static/final/abstract/empty, or adding allowed annotation for the method. 28
 Error
javadoc MissingJavadocMethod Missing a Javadoc comment. 28
 Error
design DesignForExtension Class 'Equipment' looks like designed for extension (can be subclassed), but the method 'getHeaders' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Equipment' final or making the method 'getHeaders' static/final/abstract/empty, or adding allowed annotation for the method. 32
 Error
javadoc MissingJavadocMethod Missing a Javadoc comment. 32
 Error
design DesignForExtension Class 'Equipment' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Equipment' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. 36
 Error
misc FinalParameters Parameter o should be final. 37
 Error
blocks NeedBraces 'if' construct must use '{}'s. 38
 Error
blocks NeedBraces 'if' construct must use '{}'s. 39
 Error
sizes LineLength Line is longer than 80 characters (found 166). 41
 Error
design DesignForExtension Class 'Equipment' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Equipment' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. 44

ua/lviv/iot/models/EquipmentBox.java

Severity Category Rule Message Line
 Error
sizes LineLength Line is longer than 80 characters (found 108). 3
 Error
whitespace FileTabCharacter File contains tab characters (this is the first instance). 4
 Error
whitespace OperatorWrap '+' should be on a new line. 6
 Error
whitespace OperatorWrap '+' should be on a new line. 7
 Error
whitespace OperatorWrap '+' should be on a new line. 8
 Error
whitespace OperatorWrap '+' should be on a new line. 9

ua/lviv/iot/models/Lighting.java

Severity Category Rule Message Line
 Error
whitespace FileTabCharacter File contains tab characters (this is the first instance). 6
 Error
javadoc JavadocVariable Missing a Javadoc comment. 6
 Error
javadoc JavadocVariable Missing a Javadoc comment. 7
 Error
javadoc JavadocVariable Missing a Javadoc comment. 8
 Error
sizes LineLength Line is longer than 80 characters (found 120). 10
 Error
javadoc MissingJavadocMethod Missing a Javadoc comment. 10
 Error
misc FinalParameters Parameter manufacturer should be final. 10
 Error
misc FinalParameters Parameter isRented should be final. 10
 Error
misc FinalParameters Parameter priceInUAH should be final. 10
 Error
misc FinalParameters Parameter watts should be final. 10
 Error
coding HiddenField 'watts' hides a field. 10
 Error
misc FinalParameters Parameter kelvins should be final. 10
 Error
coding HiddenField 'kelvins' hides a field. 10
 Error
misc FinalParameters Parameter model should be final. 10
 Error
coding HiddenField 'model' hides a field. 10
 Error
design DesignForExtension Class 'Lighting' looks like designed for extension (can be subclassed), but the method 'toCSV' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Lighting' final or making the method 'toCSV' static/final/abstract/empty, or adding allowed annotation for the method. 17
 Error
sizes LineLength Line is longer than 80 characters (found 100). 19
 Error
design DesignForExtension Class 'Lighting' looks like designed for extension (can be subclassed), but the method 'getHeaders' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Lighting' final or making the method 'getHeaders' static/final/abstract/empty, or adding allowed annotation for the method. 22
 Error
sizes LineLength Line is longer than 80 characters (found 87). 24
 Error
design DesignForExtension Class 'Lighting' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Lighting' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. 27
 Error
whitespace OperatorWrap '+' should be on a new line. 29
 Error
whitespace OperatorWrap '+' should be on a new line. 30
 Error
whitespace OperatorWrap '+' should be on a new line. 31
 Error
whitespace OperatorWrap '+' should be on a new line. 32
 Error
whitespace OperatorWrap '+' should be on a new line. 33
 Error
whitespace OperatorWrap '+' should be on a new line. 34
 Error
whitespace OperatorWrap '+' should be on a new line. 35
 Error
design DesignForExtension Class 'Lighting' looks like designed for extension (can be subclassed), but the method 'equals' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Lighting' final or making the method 'equals' static/final/abstract/empty, or adding allowed annotation for the method. 39
 Error
misc FinalParameters Parameter o should be final. 40
 Error
blocks NeedBraces 'if' construct must use '{}'s. 41
 Error
blocks NeedBraces 'if' construct must use '{}'s. 42
 Error
blocks NeedBraces 'if' construct must use '{}'s. 43
 Error
sizes LineLength Line is longer than 80 characters (found 119). 45
 Error
design DesignForExtension Class 'Lighting' looks like designed for extension (can be subclassed), but the method 'hashCode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Lighting' final or making the method 'hashCode' static/final/abstract/empty, or adding allowed annotation for the method. 48